| From: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | RE: Follow-up review items for update_deleted |
| Date: | 2026-09-07 07:52:59 |
| Message-ID: | TY4PR01MB17718E2E63887B0362EC2E97D94B22@TY4PR01MB17718.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Monday, September 7, 2026 2:37 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Fri, Sep 4, 2026 at 3:27 PM Zhijie Hou (Fujitsu) <houzj(dot)fnst(at)fujitsu(dot)com>
> wrote:
> I have made minor changes in the comments to make them clear. See
> attached.
>
> > >
> > > Both 4 and 5 are documented but will it be better to provide this
> > > information explicitly, say via Logging when the conflcit_slot is
> > > not getting advanced due to any of these reasons?
> >
> > We can do that. It seems to me we could make this improvement for PG20
> > at this stage. For PG19, I think we can improve the documentation to
> > make it a bit clearer instead. Amit and I discussed this off-list, and
> > See 0002 for the patch Amit shared to improve the doc.
>
> Thanks for sharing the doc updates. Can you please fold those in 0001 and
> share a combined patch?
Thanks for the changes. I've merged them, here is the updated patch.
I confirmed that the patch applies cleanly on PG19 as well.
Best Regards,
Zhijie Hou
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Re-initialize-conflict-slot-xmin-when-a-database-.patch | application/octet-stream | 19.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-09-07 07:54:35 | Re: Support for 8-byte TOAST values, round two |
| Previous Message | Nikita Malakhov | 2026-09-07 07:45:01 | Re: Direct TOAST v2, faster, smaller and no migration needed |