Re: Follow-up review items for update_deleted

On Fri, Sep 4, 2026 at 3:27 PM Zhijie Hou (Fujitsu)
<houzj(dot)fnst(at)fujitsu(dot)com> wrote:
>
> Thanks for reporting this. I think we should skip updating the slot.xmin in the
> cycle where the old worker hasn't stopped but retention has been resumed. Here's
> the updated patch that fixes this. To make it cleaner, I also refactored the
> logic slightly to centralize the decision of whether to update the slot.xmin.
>

I have made minor changes in the comments to make them clear. See attached.

> >
> > Both 4 and 5 are documented but will it be better to provide this
> > information explicitly, say via Logging when the conflcit_slot is not
> > getting advanced due to any of these reasons?
>
> We can do that. It seems to me we could make this improvement for PG20 at this
> stage. For PG19, I think we can improve the documentation to make it a bit
> clearer instead. Amit and I discussed this off-list, and See 0002 for the patch
> Amit shared to improve the doc.
>

Thanks for sharing the doc updates. Can you please fold those in 0001
and share a combined patch?

--
With Regards,
Amit Kapila.