| From: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | SATYANARAYANA NARLAPURAM <satyanarlapuram(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | shveta malik <shveta(dot)malik(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, shveta malik <shvetamalik(at)gmail(dot)com> |
| Subject: | RE: [PATCH] Release replication slot on error in SQL-callable slot functions |
| Date: | 2026-05-29 05:36:49 |
| Message-ID: | TY4PR01MB17718C386870F9DAD4B0BF9BC94162@TY4PR01MB17718.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Friday, May 29, 2026 1:11 PM SATYANARAYANA NARLAPURAM <satyanarlapuram(at)gmail(dot)com> wrote:
> Thanks for the patches, I combined these changes in my latest patch. Please find the v5.
Thanks for updating the patch.
Few comments:
1.
The patch places PG_CATCH() inside create_logical_replication_slot(), but the
caller may still error out before releasing the slot. It would be better to
catch the error at the caller level instead. The same problem exists in
copy_replication_slot(), which does not include the slot persistence logic
within its CATCH block.
2.
I have a concern about the LWLock handling added within the PG_CATCH block, see [1].
Best Regards,
Hou zj
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shveta malik | 2026-05-29 05:45:25 | Re: [PATCH] Release replication slot on error in SQL-callable slot functions |
| Previous Message | Peter Smith | 2026-05-29 05:31:01 | Re: Support EXCEPT for TABLES IN SCHEMA publications |