Re: [PATCH] Release replication slot on error in SQL-callable slot functions

Hi

On Thu, May 28, 2026 at 9:17 PM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:

> On Thu, May 28, 2026 at 10:11 AM SATYANARAYANA NARLAPURAM
> <satyanarlapuram(at)gmail(dot)com> wrote:
> > Thanks for the patches, I combined these changes in my latest patch.
> Please find the v5.
>
> Thanks for updating the patch! But, v5 patch caused a compilation failure.
>
> slotfuncs.c:119:32: error: too few arguments to function call, single
> argument 'try_disable' was not specified
> 119 | ReplicationSlotDropAcquired();
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
> ../../../src/include/replication/slot.h:338:13: note:
> 'ReplicationSlotDropAcquired' declared here
> 338 | extern void ReplicationSlotDropAcquired(bool try_disable);
> | ^ ~~~~~~~~~~~~~~~~
> slotfuncs.c:207:32: error: too few arguments to function call, single
> argument 'try_disable' was not specified
> 207 | ReplicationSlotDropAcquired();
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
> ../../../src/include/replication/slot.h:338:13: note:
> 'ReplicationSlotDropAcquired' declared here
> 338 | extern void ReplicationSlotDropAcquired(bool try_disable);
> | ^ ~~~~~~~~~~~~~~~~
> slotfuncs.c:922:32: error: too few arguments to function call, single
> argument 'try_disable' was not specified
> 922 | ReplicationSlotDropAcquired();
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
> ../../../src/include/replication/slot.h:338:13: note:
> 'ReplicationSlotDropAcquired' declared here
> 338 | extern void ReplicationSlotDropAcquired(bool try_disable);
> | ^ ~~~~~~~~~~~~~~~~
> 3 errors generated.
>

Please see the v6 patch. Upstream commit 2af1dc89282 changed the
ReplicationSlotDropAcquired signature since the patch generated.

Thanks,
Satya