Remove stale XXX comment in logical launcher

From: "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Remove stale XXX comment in logical launcher
Date: 2026-09-03 03:42:44
Message-ID: TY4PR01MB177186C8AB596F30DF704ECDC94B62@TY4PR01MB17718.jpnprd01.prod.outlook.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

I noticed one comment in the launcher that can be removed:

if (!retain_dead_tuples)
/* XXX unclear why we don't request logical decoding disable */
ReplicationSlotDropAcquired(false);

Since the conflict detection slot is a physical one, there is no logical
decoding state to disable when dropping it. The condition it depends on is also
self-evident from the surrounding code and the block comment above, which
already explains why the slot is dropped. So here is a patch to remove the XXX
comment.

Best Regards,
Zhijie Hou

Attachment Content-Type Size
v1-0001-Remove-stale-XXX-comment-in-logical-launcher.patch application/octet-stream 1.0 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nisha Moond 2026-09-03 03:52:01 Fix resource leak in FindConflictTuple() retry path
Previous Message Michael Paquier 2026-09-03 03:38:26 Re: WAIT FOR command should do some query jumbling