From bd84e8f875c9df93edf6a803cced21737c413ae1 Mon Sep 17 00:00:00 2001 From: Zhijie Hou Date: Thu, 3 Sep 2026 11:35:06 +0800 Subject: [PATCH v1] Remove stale XXX comment in logical launcher An XXX comment in launcher.c questioned why the slot drop does not request disabling logical decoding. But the conflict detection slot is a physical slot, so there is no logical decoding state to disable. Remove the comment. --- src/backend/replication/logical/launcher.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/backend/replication/logical/launcher.c b/src/backend/replication/logical/launcher.c index 313e31ff2e3..137da582fe2 100644 --- a/src/backend/replication/logical/launcher.c +++ b/src/backend/replication/logical/launcher.c @@ -1406,7 +1406,6 @@ ApplyLauncherMain(Datum main_arg) if (MyReplicationSlot) { if (!retain_dead_tuples) - /* XXX unclear why we don't request logical decoding disable */ ReplicationSlotDropAcquired(false); else if (can_update_xmin) update_conflict_slot_xmin(xmin); -- 2.43.0