| From: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: [PATCH] Support automatic sequence replication |
| Date: | 2026-03-13 07:13:48 |
| Message-ID: | TY4PR01MB169072D89B6A978E60388B87A9445A@TY4PR01MB16907.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Monday, March 9, 2026 11:13 AM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
> No major concerns on 001, just a few trivial things. Do these only if you feel
> okay about these.
>
Thanks for the reviews. I've updated the patch set addressing all comments.
In 0001, aside from addressing comments in [1][2][3][4], I've changed the
logic to delay updating the page LSN for each sequence in
pg_subscription_rel. Frequent catalog updates would generate many
invalidations, degrading the performance of the apply worker which
relies on cached data from pg_subscription_rel.
0002 adds caching of sequence information for the current subscription in the
sequence sync worker. The cache is invalidated immediately when
pg_subscription_rel is modified. Concurrent changes to sequence names or
namespaces are detected before synchronization, as the worker verifies the
sequence data at sync time.
0003 (formerly 0002) modifies REFRESH SEQUENCES to synchronize sequence values
directly without launching a worker.
[1] https://www.postgresql.org/message-id/02EDB3D2-4E5A-4EDE-BADF-3DF62D707831%40gmail.com
[2] https://www.postgresql.org/message-id/OS9PR01MB12149E4614DA95963670772EEF579A%40OS9PR01MB12149.jpnprd01.prod.outlook.com
[3] https://www.postgresql.org/message-id/CAJpy0uAmEkjsBS6RxPv9iDcK2kfJ5%3Dbq4Mq1zMCQtaYFoDfbbQ%40mail.gmail.com
[4] https://www.postgresql.org/message-id/CAJpy0uC0T_tp62zxJN_2d_A%3DYpvf14ebjGFepckeJugW5OHOyA%40mail.gmail.com
Best Regards,
Hou zj
| Attachment | Content-Type | Size |
|---|---|---|
| v12-0003-Synchronize-sequences-directly-in-REFRESH-SEQUEN.patch | application/octet-stream | 15.7 KB |
| v12-0001-Support-automatic-sequence-replication.patch | application/octet-stream | 46.4 KB |
| v12-0002-Cache-sequence-information-in-the-sequence-sync-.patch | application/octet-stream | 6.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jonathan Gonzalez V. | 2026-03-13 07:18:57 | Re: [oauth] Stabilize the libpq-oauth ABI (and allow alternative implementations?) |
| Previous Message | Zhijie Hou (Fujitsu) | 2026-03-13 07:12:49 | RE: [PATCH] Support automatic sequence replication |