RE: [PATCH] Support automatic sequence replication

From: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>
To: "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>
Cc: Ajin Cherian <itsajin(at)gmail(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>
Subject: RE: [PATCH] Support automatic sequence replication
Date: 2026-03-09 03:16:47
Message-ID: OS9PR01MB12149E4614DA95963670772EEF579A@OS9PR01MB12149.jpnprd01.prod.outlook.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dear Hou,

Thanks for uprating the patch. Few comments.

01.
The patch needs to be rebased, because of the missing inclusion of wait_event.h.
It might be affected by the commit 868825aae.

02. start_sequence_sync
Missing ProcessConfigFile() in the loop. Now it's done only in copy_sequences(),
but we can reach there when some sequences need to be synchronized.

03.
Can we describe needed privileges? IIUC, initial sync needs the UPDATE privilege,
additionally periodic synch needs SELECT privilege.

04.
```
+ long sleep_ms = SEQSYNC_MIN_SLEEP_MS;
```

This is used in the for loop, make it the loop-specific variable.

Best regards,
Hayato Kuroda
FUJITSU LIMITED

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message yangyz 2026-03-09 03:21:35 Re: Avoid resource leak (src/bin/pg_dump/pg_dumpall.c)
Previous Message shveta malik 2026-03-09 03:13:06 Re: [PATCH] Support automatic sequence replication