| From: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | Ajin Cherian <itsajin(at)gmail(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Subject: | RE: [PATCH] Support automatic sequence replication |
| Date: | 2026-03-13 07:12:49 |
| Message-ID: | TY4PR01MB169071CAF35173F414C134F049445A@TY4PR01MB16907.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Monday, March 9, 2026 11:17 AM Kuroda, Hayato/黒田 隼人 <kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
> Few comments.
Thanks for the comments.
>
> 03.
> Can we describe needed privileges? IIUC, initial sync needs the UPDATE
> privilege, additionally periodic synch needs SELECT privilege.
I could not find existing doc for the privilege required for table sync or
sequence sync, so I think we can consider that as a separate patch.
>
> 04.
> ```
> + long sleep_ms = SEQSYNC_MIN_SLEEP_MS;
> ```
>
> This is used in the for loop, make it the loop-specific variable.
This value should survive across sync loop as it's dynamically
adjusted in the loop.
Other comments have been addressed in latest version.
Best Regards,
Hou zj
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhijie Hou (Fujitsu) | 2026-03-13 07:13:48 | RE: [PATCH] Support automatic sequence replication |
| Previous Message | Zhijie Hou (Fujitsu) | 2026-03-13 07:12:09 | RE: [PATCH] Support automatic sequence replication |