RE: Add enable_groupagg GUC parameter to control GroupAggregate usage

From: Tatsuro Yamada <tatsuro(dot)yamada(at)ntt(dot)com>
To: Richard Guo <guofenglinux(at)gmail(dot)com>
Cc: Tatsuro Yamada <yamatattsu(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: RE: Add enable_groupagg GUC parameter to control GroupAggregate usage
Date: 2026-07-09 10:55:50
Message-ID: TY4P301MB12991DBFCA7ABB9A819D97CE9EFE2@TY4P301MB1299.JPNP301.PROD.OUTLOOK.COM
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Richard,

> Pushed.
>
> I still listed myself as Co-authored-by rather than Author, because I
> want to give full credit to you, as this is your idea and your patch.

Thank you for the commit!
I also appreciate your consideration in giving me full credit for the patch.

Regards,
Tatsuro Yamada

> -----Original Message-----
> From: Richard Guo <guofenglinux(at)gmail(dot)com>
> Sent: Thursday, July 9, 2026 10:02 AM
> To: Tatsuro Yamada(山田達朗) <tatsuro(dot)yamada(at)ntt(dot)com>
> Cc: Tatsuro Yamada <yamatattsu(at)gmail(dot)com>; David Rowley
> <dgrowleyml(at)gmail(dot)com>; Ashutosh Bapat
> <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>; pgsql-hackers(at)lists(dot)postgresql(dot)org
> Subject: Re: Add enable_groupagg GUC parameter to control GroupAggregate
> usage
>
> On Wed, Jul 8, 2026 at 8:54 PM Tatsuro Yamada <tatsuro(dot)yamada(at)ntt(dot)com>
> wrote:
> > I'm in favor of committing this.
> > Before you do, I'd like to clarify one point regarding the commit message.
> > Would it make sense to list both of us as authors?
> >
> > The reason I ask is that you made substantial changes to the patch,
> > including handling additional plan nodes such as SetOp and adding
> regression
> > tests. Given those contributions, I wondered whether it would be more
> > appropriate for both of us to be listed as authors. (I've seen past commits
> that
> > included two Author: lines.)
> > I'm happy to leave that decision to you.
>
> Pushed.
>
> I still listed myself as Co-authored-by rather than Author, because I
> want to give full credit to you, as this is your idea and your patch.
>
> - Richard

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Akshay Joshi 2026-07-09 10:57:41 Re: [PATCH] Add pg_get_policy_ddl() function to reconstruct CREATE POLICY statement
Previous Message Amit Kapila 2026-07-09 10:45:17 Re: Hash index bucket split bug