Re: [PATCH] Fix whole-row type errors in postgres_fdw UPDATE joins

Hi Sho,

Thanks for reviewing and testing this!

Regards,
Ziming

________________________________________
From: Sho Ito <i(dot)sho(dot)0628(at)gmail(dot)com>
Sent: Wednesday, October 28, 2026 10:00
To: Ziming Zhang
Cc: PostgreSQL Hackers
Subject: Re: [PATCH] Fix whole-row type errors in postgres_fdw UPDATE joins

On Fri, Oct 23, 2026 at 1:15 PM Ziming Zhang <toren(dot)zhang(at)outlook(dot)com<mailto:toren(dot)zhang(at)outlook(dot)com>> wrote:

The attached patch makes `search_indexed_tlist_for_var()` also compare
`vartype`, similarly to `tlist_member_match_var()`.

Hi Ziming,

I reviewed the attached patch on master with assertions enabled. The
`postgres_fdw` regression tests, `eval_plan_qual` isolation test, and all
core regression tests pass, including the new whole-row test cases.

I found no issues with the patch.

Thanks,
Sho

--
＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝
Sho Ito (Sean)

E-mail: i(dot)sho(dot)0628(at)gmail(dot)com<mailto:i(dot)sho(dot)0628(at)gmail(dot)com>
LinkedIn: https://www.linkedin.com/in/sho-ito-0628/<https://www.linkedin.com/in/sho-ito-0628/>
GitHub: https://github.com/sean0628/<https://github.com/sean0628/>
＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝