| From: | Sho Ito <i(dot)sho(dot)0628(at)gmail(dot)com> |
|---|---|
| To: | Ziming Zhang <toren(dot)zhang(at)outlook(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Fix whole-row type errors in postgres_fdw UPDATE joins |
| Date: | 2026-10-28 02:00:16 |
| Message-ID: | CAG7L5+6LL2je9X5zJfZWV15GvA0Foed45OtfzMXT38HZLQ3w-Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Oct 23, 2026 at 1:15 PM Ziming Zhang <toren(dot)zhang(at)outlook(dot)com>
wrote:
>
> The attached patch makes `search_indexed_tlist_for_var()` also compare
> `vartype`, similarly to `tlist_member_match_var()`.
>
Hi Ziming,
I reviewed the attached patch on master with assertions enabled. The
`postgres_fdw` regression tests, `eval_plan_qual` isolation test, and all
core regression tests pass, including the new whole-row test cases.
I found no issues with the patch.
Thanks,
Sho
--
=======================================
*Sho Ito (Sean)*
E-mail: i(dot)sho(dot)0628(at)gmail(dot)com
LinkedIn: *https://www.linkedin.com/in/sho-ito-0628/
<https://www.linkedin.com/in/sho-ito-0628/>*
GitHub: https://github.com/sean0628/
=======================================
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Michael Paquier | 2026-10-28 01:43:26 | Re: Fix stale relcache fields for TOAST indexes during REINDEX CONCURRENTLY |