RE: pgsql: Add key management system

From: "Shinoda, Noriyoshi (PN Japan FSIP)" <noriyoshi(dot)shinoda(at)hpe(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>, Erik Rijkers <er(at)xs4all(dot)nl>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: RE: pgsql: Add key management system
Date: 2020-12-26 14:38:40
Message-ID: TU4PR8401MB1152E92B4D44C81E496D6032EEDB0@TU4PR8401MB1152.NAMPRD84.PROD.OUTLOOK.COM
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Hi,

Thank you for developing a great feature. I tested it immediately.
The attached patch changes the value of the --file-encryption-keylen option of the initdb command to mandatory. No value is currently required.
I also changed the help message and the manual.

Regards,
Noriyoshi Shinoda

-----Original Message-----
From: Bruce Momjian [mailto:bruce(at)momjian(dot)us]
Sent: Saturday, December 26, 2020 4:01 AM
To: Erik Rijkers <er(at)xs4all(dot)nl>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add key management system

On Fri, Dec 25, 2020 at 07:30:01PM +0100, Erik Rijkers wrote:
> On 2020-12-25 16:19, Bruce Momjian wrote:
>
> > Add key management system
> > doc/src/sgml/database-encryption.sgml | 97 +++++
>
> Attached are a few typos.
>
> I also noticed that this option does not occur in the initdb --help:
>
> -u --copy-encryption-keys
>
> Was that deliberate?

No. :-( Attached patch applied. Thanks.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EnterpriseDB https://enterprisedb.com

The usefulness of a cup is in its emptiness, Bruce Lee

Attachment Content-Type Size
keylength.diff application/octet-stream 1.9 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2020-12-26 14:38:57 Re: pgsql: Add scripts for retrieving the cluster file encryption key
Previous Message Bruce Momjian 2020-12-26 14:25:16 pgsql: auth commands: list specific commands to install in Makefile

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2020-12-26 15:00:30 Re: pgsql: Add key management system
Previous Message Bruce Momjian 2020-12-26 14:25:14 Re: pgsql: Add pg_alterckey utility to change the cluster key