Re: pgsql: Add pg_alterckey utility to change the cluster key

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add pg_alterckey utility to change the cluster key
Date: 2020-12-26 14:25:14
Message-ID: 20201226142514.GI19054@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Sat, Dec 26, 2020 at 06:16:37PM +0900, Michael Paquier wrote:
> On Sat, Dec 26, 2020 at 08:29:10AM +0100, Pavel Stehule wrote:
> > I did recheck with same result
>
> The Makefile of pg_alterckey is busted, and adding --enable-tap-tests
> to the options of ./configure is enough to see a failure. In short,
> src/bin/pg_alterckey/Makefile includes the following lines, but it has
> no TAP tests as of pg_alterckey/t/:
> check:
> $(prove_check)
>
> installcheck:
> $(prove_installcheck)
>
> So this breaks.

OK, fixed.

> I would like to point out that all non-Unix buildfarm members are
> broken like fairywen because of the addition of those scripts:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=fairywren&dt=2020-12-26%2009%3A04%3A27
> /usr/bin/install: cannot stat 'crypto/ckey_aws.sh.sample': No such
> file or directory

Also fixed. I got too fancy with Makefile magic.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EnterpriseDB https://enterprisedb.com

The usefulness of a cup is in its emptiness, Bruce Lee

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2020-12-26 14:25:16 pgsql: auth commands: list specific commands to install in Makefile
Previous Message Bruce Momjian 2020-12-26 14:03:24 pgsql: pg_alterckey: remove TAP check rules from Makefile

Browse pgsql-hackers by date

  From Date Subject
Next Message Shinoda, Noriyoshi (PN Japan FSIP) 2020-12-26 14:38:40 RE: pgsql: Add key management system
Previous Message Dmitry Dolgov 2020-12-26 10:46:35 Re: pg_stat_statements and "IN" conditions