RE: Improve logging when using Huge Pages

Hello,

Thank you everyone for comments.
In the thread [1] that Horiguchi told me about, there is already a review going on about GUC for HugePages memory.
For this reason, I have removed the new GUC implementation and attached a patch that changes only the message at instance startup.

[1]
https://www.postgresql.org/message-id/20210903.141206.103927759882272221.hor

Regards,
Noriyoshi Shinoda

-----Original Message-----
From: Fujii Masao [mailto:masao(dot)fujii(at)oss(dot)nttdata(dot)com]
Sent: Saturday, September 4, 2021 1:36 AM
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>; Shinoda, Noriyoshi (PN Japan FSIP) <noriyoshi(dot)shinoda(at)hpe(dot)com>; rjuju123(at)gmail(dot)com; pgsql-hackers(at)postgresql(dot)org
Subject: Re: Improve logging when using Huge Pages

On 2021/09/03 23:27, Tom Lane wrote:
> Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> writes:
>> IMO, if the level is promoted to LOG, the message should be updated
>> so that it follows the error message style guide. But I agree that
>> simpler message would be better in this case. So what about something
>> like the following?
>
>> LOG: could not map anonymous shared memory (%zu bytes) with huge
>> pages enabled
>> HINT: The server will map anonymous shared memory again with huge pages disabled.
>
> That is not a hint. Maybe it qualifies as errdetail, though.

Yes, agreed.

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION