| From: | "Shinoda, Noriyoshi (PN Japan GCS Delivery)" <noriyoshi(dot)shinoda(at)hpe(dot)com> |
|---|---|
| To: | Lukas Fittl <lukas(at)fittl(dot)com>, Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | RE: auto_explain: Include JIT output if applicable |
| Date: | 2018-09-29 05:04:25 |
| Message-ID: | TU4PR8401MB04302231DCF0E0B1D9252936EEED0@TU4PR8401MB0430.NAMPRD84.PROD.OUTLOOK.COM |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
I tried this feature.
I think that 'if (es->costs)' of the source code auto_explain.c will always be ‘true’.
Because it is not changed after 'es-> cost = true' in NewExplainState () function several rows ago.
So I attached a patch to delete this if statement.
Regards,
Noriyoshi Shinoda
From: Lukas Fittl [mailto:lukas(at)fittl(dot)com]
Sent: Tuesday, September 25, 2018 6:38 AM
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: auto_explain: Include JIT output if applicable
On Mon, Sep 24, 2018 at 1:48 PM, Andres Freund <andres(at)anarazel(dot)de<mailto:andres(at)anarazel(dot)de>> wrote:
Thanks for noticing - pushed!
Thanks!
Best,
Lukas
--
Lukas Fittl
| Attachment | Content-Type | Size |
|---|---|---|
| auto_explain.diff | application/octet-stream | 703 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-09-29 05:11:11 | Re: auto_explain: Include JIT output if applicable |
| Previous Message | Tom Lane | 2018-09-29 04:40:58 | Re: [HACKERS] Something for the TODO list: deprecating abstime and friends |