| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | "Shinoda, Noriyoshi (PN Japan GCS Delivery)" <noriyoshi(dot)shinoda(at)hpe(dot)com> |
| Cc: | Lukas Fittl <lukas(at)fittl(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: auto_explain: Include JIT output if applicable |
| Date: | 2018-09-29 05:11:11 |
| Message-ID: | 20180929051110.sv65qp5pigawhvhg@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2018-09-29 05:04:25 +0000, Shinoda, Noriyoshi (PN Japan GCS Delivery) wrote:
> I tried this feature.
> I think that 'if (es->costs)' of the source code auto_explain.c will always be ‘true’.
>
> Because it is not changed after 'es-> cost = true' in NewExplainState () function several rows ago.
> So I attached a patch to delete this if statement.
I think it's better to stay closer to what explain.c itself is doing -
it's not like that if statement costs us anything really...
- Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shinoda, Noriyoshi (PN Japan GCS Delivery) | 2018-09-29 05:15:16 | RE: auto_explain: Include JIT output if applicable |
| Previous Message | Shinoda, Noriyoshi (PN Japan GCS Delivery) | 2018-09-29 05:04:25 | RE: auto_explain: Include JIT output if applicable |