| From: | Japin Li <japinli(at)hotmail(dot)com> |
|---|---|
| To: | Andrey Silitskiy <a(dot)silitskiy(at)postgrespro(dot)ru> |
| Cc: | Ronan Dunklau <ronan(at)dunklau(dot)fr>, Vitaly Davydov <v(dot)davydov(at)postgrespro(dot)ru>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "Takamichi Osumi (Fujitsu)" <osumi(dot)takamichi(at)fujitsu(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "sawada(dot)mshk(at)gmail(dot)com" <sawada(dot)mshk(at)gmail(dot)com>, "michael(at)paquier(dot)xyz" <michael(at)paquier(dot)xyz>, "peter(dot)eisentraut(at)enterprisedb(dot)com" <peter(dot)eisentraut(at)enterprisedb(dot)com>, "dilipbalaut(at)gmail(dot)com" <dilipbalaut(at)gmail(dot)com>, "andres(at)anarazel(dot)de" <andres(at)anarazel(dot)de>, "amit(dot)kapila16(at)gmail(dot)com" <amit(dot)kapila16(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Greg Sabino Mullane <htamfids(at)gmail(dot)com>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Subject: | Re: Exit walsender before confirming remote flush in logical replication |
| Date: | 2026-03-04 01:59:20 |
| Message-ID: | SY7PR01MB1092193C8AAAB9DD32341E72FB67CA@SY7PR01MB10921.ausprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 03 Mar 2026 at 14:08, Andrey Silitskiy <a(dot)silitskiy(at)postgrespro(dot)ru> wrote:
> On Feb 10, 2026 Ronan Dunklau <ronan(at)dunklau(dot)fr> wrote:
>> - however, if one were to stop the service before doing a pg_upgrade,
>> they would have no other choice than either disable the behaviour
>> entirely (by switching to wait_flush) or fail the upgrade if a logical
>> replication slot is pending changes.
>
> I agree with you, this idea is more flexible. So I changed the interface
> from the one discussed in this thread from the very beginning to a timeout.
> Propose an updated patch.
>
> Best Regards,
> Andrey
>
At first glance, wal_sender_shutdown_timeout seems to have the wrong type.
It should be an integer, not an enum.
+ <term><varname>wal_sender_shutdown_timeout</varname> (<type>enum</type>)
> [2. text/x-patch; v1-0001-Introduce-a-new-GUC-wal_sender_shutdown_timeout.patch]...
--
Regards,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2026-03-04 02:27:36 | Re: Correcting freeze conflict horizon calculation |
| Previous Message | Japin Li | 2026-03-04 01:40:30 | Re: Don't keep closed WAL segment in page cache after replay |