| From: | Andrey Silitskiy <a(dot)silitskiy(at)postgrespro(dot)ru> |
|---|---|
| To: | Ronan Dunklau <ronan(at)dunklau(dot)fr> |
| Cc: | Vitaly Davydov <v(dot)davydov(at)postgrespro(dot)ru>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "Takamichi Osumi (Fujitsu)" <osumi(dot)takamichi(at)fujitsu(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "sawada(dot)mshk(at)gmail(dot)com" <sawada(dot)mshk(at)gmail(dot)com>, "michael(at)paquier(dot)xyz" <michael(at)paquier(dot)xyz>, "peter(dot)eisentraut(at)enterprisedb(dot)com" <peter(dot)eisentraut(at)enterprisedb(dot)com>, "dilipbalaut(at)gmail(dot)com" <dilipbalaut(at)gmail(dot)com>, "andres(at)anarazel(dot)de" <andres(at)anarazel(dot)de>, "amit(dot)kapila16(at)gmail(dot)com" <amit(dot)kapila16(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Greg Sabino Mullane <htamfids(at)gmail(dot)com>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Subject: | Re: Exit walsender before confirming remote flush in logical replication |
| Date: | 2026-03-03 07:08:52 |
| Message-ID: | 6ed7f4ed-aac1-4ce9-a692-7062a4bb07f6@postgrespro.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Feb 10, 2026 Ronan Dunklau <ronan(at)dunklau(dot)fr> wrote:
> - however, if one were to stop the service before doing a pg_upgrade,
> they would have no other choice than either disable the behaviour
> entirely (by switching to wait_flush) or fail the upgrade if a logical
> replication slot is pending changes.
I agree with you, this idea is more flexible. So I changed the interface
from the one discussed in this thread from the very beginning to a timeout.
Propose an updated patch.
Best Regards,
Andrey
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Introduce-a-new-GUC-wal_sender_shutdown_timeout.patch | text/x-patch | 16.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2026-03-03 07:32:29 | Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access) |
| Previous Message | Peter Eisentraut | 2026-03-03 06:38:18 | Re: Change COPY ... ON_ERROR ignore to ON_ERROR ignore_row |