Re: GIN pageinspect support for entry tree and posting tree

On Wed, 02 Sep 2026 at 00:10, Japin Li <japinli(at)hotmail(dot)com> wrote:
> Hi, Andrey and Kirill
>
> On Sun, 30 Aug 2026 at 22:46, Andrey Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
>>> On 3 Aug 2026, at 17:40, Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
>>>
>>> Hi all,
>>>
>>> I have rebased patches and did little polishing for error
>>> messages/overall style. Posting to see how new CI reacts & also bump
>>> thread.
>>>
>> Hi Kirill,
>>
>> The CF entry is still Ready for Committer, but Japin's August 13 review
>> found that gin_entrypage_items() does not finalize its temporary tuple
>> descriptor before index_getattr(). With assertions enabled, the new
>> check added by c456e391138 can fail here.
>>
>> Could you fold the proposed TupleDescFinalize() call into a new patch
>> version? I have moved the entry to Waiting on Author for now.
>>
>
> The v20260308 patches need a rebase due to commit 51c43a5dbd86. I've rebased
> and merged the fix from [1]. Please take a look.
>
> [1] https://www.postgresql.org/message-id/SY7PR01MB109210C8E9DEB6BF5FFEA7A81B6DB2%40SY7PR01MB10921.ausprd01.prod.outlook.com
>

Sorry, I forgot to update the patches.

--
Regards,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.