| From: | Japin Li <japinli(at)hotmail(dot)com> |
|---|---|
| To: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
| Cc: | Kirill Reshke <reshkekirill(at)gmail(dot)com>, Roman Khapov <rkhapov(at)yandex-team(dot)ru>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: GIN pageinspect support for entry tree and posting tree |
| Date: | 2026-09-01 16:10:23 |
| Message-ID: | SY7PR01MB1092135B5753972F5CF4A99E0B6A82@SY7PR01MB10921.ausprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi, Andrey and Kirill
On Sun, 30 Aug 2026 at 22:46, Andrey Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
>> On 3 Aug 2026, at 17:40, Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
>>
>> Hi all,
>>
>> I have rebased patches and did little polishing for error
>> messages/overall style. Posting to see how new CI reacts & also bump
>> thread.
>>
> Hi Kirill,
>
> The CF entry is still Ready for Committer, but Japin's August 13 review
> found that gin_entrypage_items() does not finalize its temporary tuple
> descriptor before index_getattr(). With assertions enabled, the new
> check added by c456e391138 can fail here.
>
> Could you fold the proposed TupleDescFinalize() call into a new patch
> version? I have moved the entry to Waiting on Author for now.
>
The v20260308 patches need a rebase due to commit 51c43a5dbd86. I've rebased
and merged the fix from [1]. Please take a look.
--
Regards,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2026-09-01 16:26:39 | Re: [PATCH] Remove dead code in pg_dump |
| Previous Message | Alberto Piai | 2026-09-01 15:41:31 | Re: Adding a stored generated column without long-lived locks |