| From: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Kirill Reshke <reshkekirill(at)gmail(dot)com> |
| Cc: | Japin Li <japinli(at)hotmail(dot)com>, Roman Khapov <rkhapov(at)yandex-team(dot)ru>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: GIN pageinspect support for entry tree and posting tree |
| Date: | 2026-08-30 17:46:07 |
| Message-ID: | E918F3EB-7706-4657-AC13-95CF05131298@yandex-team.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 3 Aug 2026, at 17:40, Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
>
> Hi all,
>
> I have rebased patches and did little polishing for error
> messages/overall style. Posting to see how new CI reacts & also bump
> thread.
>
Hi Kirill,
The CF entry is still Ready for Committer, but Japin's August 13 review
found that gin_entrypage_items() does not finalize its temporary tuple
descriptor before index_getattr(). With assertions enabled, the new
check added by c456e391138 can fail here.
Could you fold the proposed TupleDescFinalize() call into a new patch
version? I have moved the entry to Waiting on Author for now.
Thank you!
Best regards, Andrey Borodin.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey Borodin | 2026-08-30 17:54:36 | Re: convert various variables to atomics |
| Previous Message | Andrey Borodin | 2026-08-30 17:42:44 | Re: CREATE TABLE LIKE INCLUDING TRIGGERS |