Re: [PATCHES] guc

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Liam Stewart <liams(at)redhat(dot)com>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] guc
Date: 2002-01-18 05:17:57
Message-ID: Pine.LNX.4.30.0201172209290.725-100000@peter.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane writes:

> [ raises eyebrow ] To my mind that was one of the principal reasons
> for working on such a thing at all. If you don't want to allow this,
> then what alternative solution do you have for our geometry regression
> test mess? (Defining it as not a mess won't fly.)

I did some investigation and noticed that the different geometry expected
files differ in the same 5 groups of places (or less), and in 4 of those
places there are only two possible variations. So that at least gives me
the idea that perhaps the geometry test could be split up in two or three
tests, and that would probably reduce the relative number of "nonstandard"
expected files we'd need.

One difference case is a system failing to implement negative zeros.
Setting the output precision won't fix that.

Actually, I just took a peak into include/utils/geo_decls.h, and the
definiton of EPSILON at the top leaves me to think that printing out
anything more than 6 significant digits is nonsense anyway. Numerical
analysts would probably shudder.

--
Peter Eisentraut peter_e(at)gmx(dot)net

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Josh Berkus 2002-01-18 05:18:27 Re: UPDATE Query problem
Previous Message Bruce Momjian 2002-01-18 05:12:23 Re: tuptoaster.c must *not* use SnapshotAny

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2002-01-18 05:21:02 Re: [PATCHES] guc
Previous Message Elliot Lee 2002-01-17 23:25:16 Re: postgresql-7.2b3-betterquote.patch