Re: [PATCHES] guc

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> Liam Stewart writes:
>> I've removed
>> GetConfigOption() and replaced it with ShowConfigOption() which does an
>> elog(NOTICE) instead of returning a string.

> I certainly don't like that. I want to be able to get at the
> configuration setting without any notice going off.

I agree with Peter --- better to separate the getting of the string
from displaying it. What's the reason for collapsing them together?

>> When setting REAL_FORMAT and DOUBLE_PRECISION_FORMAT, the printf-style
>> format string should be checked for certain things:

> I wouldn't use a printf format string at all.

Good point. If we have to set up a checking mechanism then we should
ask ourselves why we're bothering to use printf representation.

> What I would like to get out of the configurability of floating-point
> numbers is:
> 1. The ability to dump them in binary or hex format for lossless
> dump/reload. (printf("%a") does that.)

On some platforms... I'd be happier with this if it were more portable...

> Some people will also suggest
> 3. Be able to set the number of significant digits that are shown.

> to allow simplifying the regression tests, but I do not think that that is
> a good idea,

[ raises eyebrow ] To my mind that was one of the principal reasons
for working on such a thing at all. If you don't want to allow this,
then what alternative solution do you have for our geometry regression
test mess? (Defining it as not a mess won't fly.)

regards, tom lane