Re: [PATCHES] encoding names

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>
Cc: <zakkr(at)zf(dot)jcu(dot)cz>, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, <barry(at)xythos(dot)com>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] encoding names
Date: 2001-08-23 15:36:01
Message-ID: Pine.LNX.4.30.0108231728310.677-100000@peter.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tatsuo Ishii writes:

> > But getdbencoding isn't semantically different from the old
> > getdatabaseencoding. "encoding" isn't the right term anyway, methinks, it
> > should be "character set". So maybe database_character_set()? (No "get"
> > please.)
>
> I'm not a native English speaker, so please feel free to choose more
> appropriate name.
>
> BTW, what's wrong with "encoding"? I don't think, for example EUC-JP
> or utf-8, are character set names.

Hmm, SQL talks of character sets, it has a CHARACTER_SETS view and such.
It's slightly incorrect, I agree.

Maybe we should not touch getdatabaseencoding() right now, given that the
names we currently use are apparently almost correct anyway and
considering the pain it creates to alter them, and instead implement the
information schema views in the future?

--
Peter Eisentraut peter_e(at)gmx(dot)net http://funkturm.homeip.net/~peter

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2001-08-23 16:15:10 Re: A couple items on TODO
Previous Message mlw 2001-08-23 15:26:42 OLAP, Aggregates, and order of operations

Browse pgsql-patches by date

  From Date Subject
Next Message Vsevolod Lobko 2001-08-23 16:45:05 Patch for pl/tcl Tcl_ExternalToUtf and Tcl_UtfToExternal support
Previous Message Karel Zak 2001-08-23 07:51:14 Re: encoding names v2.