RE: Column Filtering in Logical Replication

From: "Shinoda, Noriyoshi (PN Japan FSIP)" <noriyoshi(dot)shinoda(at)hpe(dot)com>
To: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>
Subject: RE: Column Filtering in Logical Replication
Date: 2022-03-26 04:09:17
Message-ID: PH7PR84MB18850A74D275F39762059E6CEE1B9@PH7PR84MB1885.NAMPRD84.PROD.OUTLOOK.COM
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello,

The 'prattrs' column has been added to the pg_publication_rel catalog,
but the current commit to catalog.sgml seems to have added it to pg_publication_namespace.
The attached patch fixes this.

Regards,
Noriyoshi Shinoda
-----Original Message-----
From: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
Sent: Saturday, March 26, 2022 9:35 AM
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>; houzj(dot)fnst(at)fujitsu(dot)com; Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>; Justin Pryzby <pryzby(at)telsasoft(dot)com>; Rahila Syed <rahilasyed90(at)gmail(dot)com>; Peter Smith <smithpb2250(at)gmail(dot)com>; pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>; shiy(dot)fnst(at)fujitsu(dot)com
Subject: Re: Column Filtering in Logical Replication

On 3/26/22 01:18, Tomas Vondra wrote:
>
> ...
>
> I went over the patch again, polished the commit message a bit, and
> pushed. May the buildfarm be merciful!
>

There's a couple failures immediately after the push, which caused me a minor heart attack. But it seems all of those are strange failures related to configure (which the patch did not touch at all), on animals managed by Andres. And a couple animals succeeded since then.

So I guess the animals were reconfigured, or something ...

regards

--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
prattrs_column_fix_v1.diff application/octet-stream 1.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bharath Rupireddy 2022-03-26 05:01:01 Re: pg_walinspect - a new extension to get raw WAL data and WAL stats
Previous Message Justin Pryzby 2022-03-26 03:13:53 Re: pgsql: Add 'basebackup_to_shell' contrib module.