| From: | "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Handle infinite recursion in logical replication setup |
| Date: | 2022-05-24 02:36:48 |
| Message-ID: | OSZPR01MB6310A99912BFB8291EF003FAFDD79@OSZPR01MB6310.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, May 24, 2022 1:34 AM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> Thanks for the comments, the attached v15 patch has the fixes for the same.
>
Thanks for updating the patch. I have a comment on the document in 0002 patch.
@@ -300,6 +310,11 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
replication from the publisher. The default is
<literal>false</literal>.
</para>
+ <para>
+ There is some interaction between the <literal>only_local</literal>
+ option and <literal>copy_data</literal> option. Refer to the
+ <xref linkend="sql-createsubscription-notes" /> for details.
+ </para>
</listitem>
</varlistentry>
This change is related to "only_local" option and "copy_data" option, so I think
it should be put together with "only_local", instead of "disable_on_error".
Besides, I tested some cross version cases, pg_dump and describe command, the
results are all as expected.
Regards,
Shi yu
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jonathan S. Katz | 2022-05-24 02:49:42 | Re: allow building trusted languages without the untrusted versions |
| Previous Message | Michael Paquier | 2022-05-24 02:33:36 | Re: Patch: Don't set LoadedSSL unless secure_initialize succeeds |