From: | vignesh C <vignesh21(at)gmail(dot)com> |
---|---|
To: | "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com> |
Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Handle infinite recursion in logical replication setup |
Date: | 2022-05-25 11:56:32 |
Message-ID: | CALDaNm0_0nirp9qQQnP8-Za+BtOm_Zd13b9cnd6Whs-A8hhpug@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, May 24, 2022 at 8:06 AM shiy(dot)fnst(at)fujitsu(dot)com
<shiy(dot)fnst(at)fujitsu(dot)com> wrote:
>
> On Tue, May 24, 2022 1:34 AM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> >
> > Thanks for the comments, the attached v15 patch has the fixes for the same.
> >
>
> Thanks for updating the patch. I have a comment on the document in 0002 patch.
>
> @@ -300,6 +310,11 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
> replication from the publisher. The default is
> <literal>false</literal>.
> </para>
> + <para>
> + There is some interaction between the <literal>only_local</literal>
> + option and <literal>copy_data</literal> option. Refer to the
> + <xref linkend="sql-createsubscription-notes" /> for details.
> + </para>
> </listitem>
> </varlistentry>
>
> This change is related to "only_local" option and "copy_data" option, so I think
> it should be put together with "only_local", instead of "disable_on_error".
Modified.
The v16 patch attached at [1] has the changes for the same.
[1] - https://www.postgresql.org/message-id/CALDaNm2_Ytder-6C68ia%3Dm39cmknAhxf2KGkeNAtxt84MxMT3w%40mail.gmail.com
Regards,
Vignesh
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2022-05-25 12:25:44 | Re: HOLD_INTERRUPTS() vs ProcSignalBarrier |
Previous Message | vignesh C | 2022-05-25 11:55:02 | Re: Handle infinite recursion in logical replication setup |