RE: [PATCH] Proposal: Improvements to PDF stylesheet and table column widths

From: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>
To: 'Noboru Saito' <noborusai(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Florents Tselai <florents(dot)tselai(at)gmail(dot)com>
Subject: RE: [PATCH] Proposal: Improvements to PDF stylesheet and table column widths
Date: 2025-06-09 07:17:12
Message-ID: OSCPR01MB14966B70DC510DEB6262D5CE5F56BA@OSCPR01MB14966.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dear Saito-san,

> - A patch that adds margins to admonition blocks.
> - An updated image where I have highlighted the space with a red
> border for clarity.
>
> The image shows:
> - The original layout (top left)
> - Only indentation set to 0 (top right)
> - Indentation 0 plus admonition margins (bottom right)

To confirm, the top-right was generated with the previous patch, and bottom-right
was generated v2 patch, right? I prefer the bottom-right one.

BTW, I can suggest separating patches like:

0001 - setting both body.start.indent and body.end.indent to 0
0002 - set margin-left and margin-right to 0.25in

This approach makes us easier to understand and discuss, i.e., someone only loves
0001. They can be combined by committers when they push changes.
To create a series of patches, you can git format-patch command can be used.
Please refer [1] for more detail.

[1]: https://git-scm.com/book/en/v2/Appendix-C:-Git-Commands-Email

Best regards,
Hayato Kuroda
FUJITSU LIMITED

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message wenhui qiu 2025-06-09 07:17:19 Re: [PATCH] Refactor: Extract XLogRecord info
Previous Message Shinya Kato 2025-06-09 07:10:34 Extend COPY FROM with HEADER <integer> to skip multiple lines