Re: [PATCH] Proposal: Improvements to PDF stylesheet and table column widths

From: Noboru Saito <noborusai(at)gmail(dot)com>
To: Florents Tselai <florents(dot)tselai(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Proposal: Improvements to PDF stylesheet and table column widths
Date: 2025-06-04 05:37:04
Message-ID: CAAM3qnJtfN7Soi=kFr5uT6cD=80vVGAy-C05ygy1n0=gi5Mauw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

Thank you very much for your feedback.

From my own testing, I believe that setting the indentation to zero does not
introduce any issues in the generated PDFs. If I had to mention a possible
side effect, it might be that admonition blocks become a bit more visually
prominent on the right side of the page.

To address this, I thought it could be helpful to add left and right margins
to nongraphical.admonition.properties so that admonitions are more centered.
I am attaching two files for your reference:

- A patch that adds margins to admonition blocks.
- An updated image where I have highlighted the space with a red
border for clarity.

The image shows:
- The original layout (top left)
- Only indentation set to 0 (top right)
- Indentation 0 plus admonition margins (bottom right)

Please let me know if you have any thoughts or further suggestions.

Best regards,
Noboru Saito

2025年6月1日(日) 18:27 Florents Tselai <florents(dot)tselai(at)gmail(dot)com>:
>
>
>
> > On 30 May 2025, at 8:27 AM, Noboru Saito <noborusai(at)gmail(dot)com> wrote:
> >
> > Thank you Kuroda-san.
> >
> >> To confirm, generated pdf with current setting is left slide, and it would
> >> become like right side, is it correct? I prefer right one.
> >
> > Sorry for the lack of explanation.
> > That's right, the version on the left is the previous version,
> > and the version on the right has the patch applied.
>
> Thanks for starting this thread; the documentation could use some love.
>
> The patch applies cleanly for me and I can reproduce the screenshot shared above.
> Indeed I prefer the new margins too; the existing layout wastes too much whitespace indeed.
>

Attachment Content-Type Size
improve-stylesheet-fo-2.diff text/x-patch 1.1 KB
postgres-A4.png image/png 688.2 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2025-06-04 05:40:32 Re: Add --system-identifier / -s option to pg_resetwal
Previous Message Michael Paquier 2025-06-04 05:11:55 Re: fix notes about password encryption in pg_authid docs