From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
---|---|
To: | 'Fujii Masao' <masao(dot)fujii(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | RE: Invalid primary_slot_name triggers warnings in all processes on reload |
Date: | 2025-10-21 08:00:47 |
Message-ID: | OSCPR01MB149663E070BD86985126FC24FF5F2A@OSCPR01MB14966.jpnprd01.prod.outlook.com |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Dear Fujii-san,
> No comments on the latest patches — maybe that’s a good
> sign of their quality? ;)
>
> Anyway, unless there are any objections, I plan to commit at least
> the 0001 patch and backpatch it to all supported branches. I've
> attached the patches for the back branches for reference.
FYI, the patch could not be applied cleanly for PG13 and 14 for my env:
```
postgres (REL_13_STABLE $%=)$ git am ../patches/primary_slot_name/v6-0001-PG13-PG15-Make-invalid-primary_slot_name-follow-standard-GU.txt
Applying: Make invalid primary_slot_name follow standard GUC error reporting.
error: patch failed: src/include/replication/slot.h:208
error: src/include/replication/slot.h: patch does not apply
...
```
Cosmetic comments:
```
+ if (!ReplicationSlotValidateNameInternal(name,
+ &err_code, &err_msg, &err_hint))
...
-ReplicationSlotValidateName(const char *name, int elevel)
+ReplicationSlotValidateNameInternal(const char *name,
+ int *err_code, char **err_msg, char **err_hint)
```
Patches for older branches have strange indent, maybe because
"bool allow_reserved_name" is just removed. Should we move up arguments?
> Regarding the backpatch: in v17 and earlier, since errhint_internal()
> doesn't exist, I used errhint() instead. That means the hint message
> might be translated twice, but I think that's minor and acceptable.
> Or do you think we should instead backpatch errhint_internal() to
> those older branches to avoid the double translation?
Personally considered it can be added...
Best regards,
Hayato Kuroda
FUJITSU LIMITED
From | Date | Subject | |
---|---|---|---|
Next Message | Álvaro Herrera | 2025-10-21 08:05:37 | Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part |
Previous Message | Chao Li | 2025-10-21 07:55:46 | Re: Why cannot alter a column's type when it's used by a generated column |