Re: Invalid primary_slot_name triggers warnings in all processes on reload

On Fri, Oct 10, 2025 at 2:52 PM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> On Thu, Oct 9, 2025 at 2:26 PM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> > > Please note that since you're using already translated strings as
> > > arguments, you must use errmsg_internal() and errhint_internal(), to
> > > avoid doubly-translating these messages.
> >
> > I've updated the patch to use errmsg_internal() and errhint_internal().
> > However, for GUCs, GUC_check_errdetail() and GUC_check_errhint() are
> > still used - and since they also translate their input, we might need
> > something like GUC_check_errdetail_internal() and
> > GUC_check_errhint_internal() to avoid double translation. Thought?
> > I haven't added those functions in the attached patch yet.
>
> OK, I've implemented this and attached two patches.
>
> 0001 fixes the issue we've been discussing. It's mostly the same as
> the previous version I posted.

No comments on the latest patches — maybe that’s a good
sign of their quality? ;)

Anyway, unless there are any objections, I plan to commit at least
the 0001 patch and backpatch it to all supported branches. I've
attached the patches for the back branches for reference.

Regarding the backpatch: in v17 and earlier, since errhint_internal()
doesn't exist, I used errhint() instead. That means the hint message
might be translated twice, but I think that's minor and acceptable.
Or do you think we should instead backpatch errhint_internal() to
those older branches to avoid the double translation?

Regards,

--
Fujii Masao