RE: [PATCH] pgbench: improve \sleep meta command

From: "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>
To: 'Fujii Masao' <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, 'miyake_kouta' <miyake_kouta(at)oss(dot)nttdata(dot)com>
Cc: Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: RE: [PATCH] pgbench: improve \sleep meta command
Date: 2021-03-08 07:33:05
Message-ID: OSBPR01MB3157A625659BCC99E48D76A8F5939@OSBPR01MB3157.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dear Fujii-san, Miyake-san

> Isn't it better to accept even negative sleep time like currently pgbench does?
> Otherwise we always need to check the variable is a positive integer
> (for example, using \if command) when using it as the sleep time in \sleep
> command. That seems inconvenient.

Both of them are acceptable for me.
But we should write down how it works when the negative value is input if we adopt.

Best Regards,
Hayato Kuroda
FUJITSU LIMITED

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andy Fan 2021-03-08 07:43:36 Re: Huge memory consumption on partitioned table with FKs
Previous Message Michael Paquier 2021-03-08 07:30:23 Re: alter table set TABLE ACCESS METHOD