| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | 'Fujii Masao' <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, 'miyake_kouta' <miyake_kouta(at)oss(dot)nttdata(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] pgbench: improve \sleep meta command |
| Date: | 2021-03-08 14:10:26 |
| Message-ID: | 20210308141026.GA23615@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-Mar-08, kuroda(dot)hayato(at)fujitsu(dot)com wrote:
> Dear Fujii-san, Miyake-san
>
> > Isn't it better to accept even negative sleep time like currently pgbench does?
> > Otherwise we always need to check the variable is a positive integer
> > (for example, using \if command) when using it as the sleep time in \sleep
> > command. That seems inconvenient.
>
> Both of them are acceptable for me.
> But we should write down how it works when the negative value is input if we adopt.
Not sleeping at all seems a good reaction (same as for zero, I guess.)
--
Álvaro Herrera 39°49'30"S 73°17'W
"XML!" Exclaimed C++. "What are you doing here? You're not a programming
language."
"Tell that to the people who use me," said XML.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robins Tharakan | 2021-03-08 14:13:02 | Re: pg_upgrade failing for 200+ million Large Objects |
| Previous Message | Amit Langote | 2021-03-08 13:48:39 | Re: Parallel INSERT (INTO ... SELECT ...) |