| From: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | shveta malik <shveta(dot)malik(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Subject: | RE: Conflict detection for update_deleted in logical replication |
| Date: | 2025-09-08 11:20:32 |
| Message-ID: | OS9PR01MB169139908EC924856F187825F940CA@OS9PR01MB16913.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Monday, September 8, 2025 3:13 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Fri, Sep 5, 2025 at 5:03 PM Zhijie Hou (Fujitsu) <houzj(dot)fnst(at)fujitsu(dot)com>
> wrote:
> >
> > Here are v2 patches which addressed above comments.
> >
>
> I have pushed the first patch. I find that the test can't reliably fail without a fix.
> Can you please investigate it?
Thank you for catching this issue. I confirmed that the test may have tested
VACCUM before slot.xmin was advanced. Therefore, to improve the test, I modified
test to wait for the publisher's request message appearing twice, as after the
fix, the apply worker should keep waiting for publisher status until the
prepared txn is committed.
Also, to reduce test time, I moved the test into the existing 035 test.
Here is the updated test.
Best Regards,
Hou zj
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Add-a-race-condition-test.patch | application/octet-stream | 9.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Vivek Gadge | 2025-09-08 11:39:21 | Re: Query Performance Degradation Due to Partition Scan Order – PostgreSQL v17.6 |
| Previous Message | David Geier | 2025-09-08 11:00:10 | Re: Use merge-based matching for MCVs in eqjoinsel |