RE: BUG #19547: libpqrcv_create_slot dereferences NULL on a malformed CREATE_REPLICATION_SLOT reply

From: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>
To: 'Kenny Chen' <kennychen851228(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: "1217816127(at)qq(dot)com" <1217816127(at)qq(dot)com>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org>
Subject: RE: BUG #19547: libpqrcv_create_slot dereferences NULL on a malformed CREATE_REPLICATION_SLOT reply
Date: 2026-07-16 00:36:15
Message-ID: OS9PR01MB1214957C5C51D521A4D7FFA9BF5C72@OS9PR01MB12149.jpnprd01.prod.outlook.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Dear Kenny,

> Right, CREATE_REPLICATION_SLOT always returns exactly 4 columns, so != 4 is
> more accurate. v3 attached uses != 4 and drops "or more" from the errdetail.

Basically LGTM. From my perspective the code comment might be too detail:
"CREATE_REPLICATION_SLOT has always returned a single row with four columns"
might be enough. But it's not the strong opinion - let's confirm the Fujii-san's idea.

Best regards,
Hayato Kuroda
FUJITSU LIMITED

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Peter Geoghegan 2026-07-16 01:26:22 Re: Bug in heap_get_root_tuples
Previous Message Richard Guo 2026-07-16 00:29:25 Re: Bug in heap_get_root_tuples