| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | Kenny Chen <kennychen851228(at)gmail(dot)com>, "1217816127(at)qq(dot)com" <1217816127(at)qq(dot)com>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #19547: libpqrcv_create_slot dereferences NULL on a malformed CREATE_REPLICATION_SLOT reply |
| Date: | 2026-07-16 04:45:41 |
| Message-ID: | CAHGQGwHDwn+2fH9q99NxJyOqKRET0sCP=_pb01+Ahx+XmXi_QA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Thu, Jul 16, 2026 at 9:36 AM Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> Dear Kenny,
>
> > Right, CREATE_REPLICATION_SLOT always returns exactly 4 columns, so != 4 is
> > more accurate. v3 attached uses != 4 and drops "or more" from the errdetail.
>
> Basically LGTM. From my perspective the code comment might be too detail:
> "CREATE_REPLICATION_SLOT has always returned a single row with four columns"
> might be enough.
+1
So I've updated the comment to a simpler version and pushed the patch. Thanks!
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Maaz Syed Adeeb | 2026-07-16 05:20:36 | Re: CREATE INDEX with an expression in an INCLUDE column fails with XX000 "unrecognized node type" instead of 0A000 on master |
| Previous Message | Peter Geoghegan | 2026-07-16 01:26:22 | Re: Bug in heap_get_root_tuples |