RE: [PATCH] Add a check_hook for output_plugin_libraries

From: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>
To: 'Jacob Champion' <jacob(dot)champion(at)enterprisedb(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: RE: [PATCH] Add a check_hook for output_plugin_libraries
Date: 2026-11-11 05:00:27
Message-ID: OS7PR01MB18317FE8131BD804AFADFDF90F5712@OS7PR01MB18317.jpnprd01.prod.outlook.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Jacob,

I confirmed your push, LGTM.

> We don't seem to have a unified style for can't-happen elog calls, but
> I changed it to use "internal error:" to make it more clear that
> someone should tell us if it happens.

FYI, I could not find existing "internal error:" prefix in the backend codes,
but personally it looks OK. Nobody would see it. I can follow the manner when
I will add similar elog(ERROR).

Best regards,
Hayato Kuroda
FUJITSU LIMITED

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Sho Ito 2026-11-11 05:09:50 Re: [PATCH] psql: Fix REPACK index completion after a column list
Previous Message Manu 2026-11-11 04:54:29 Re: REPACK enhancements