| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Masahiko Sawada' <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Sergei Patiakin <sergei(dot)patiakin(at)enterprisedb(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "msawada(at)postgresql(dot)org" <msawada(at)postgresql(dot)org> |
| Subject: | RE: Session in aborted transaction misses effective_wal_level change |
| Date: | 2026-10-06 07:20:56 |
| Message-ID: | OS7PR01MB18317F5892929AECAF46CE01AF5952@OS7PR01MB18317.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Sawada-san,
> Thank you for the comments. I'm now convinced that we can call it
> after resetting the top-level XID. I was concerned about the
> inconsistency between the AtEOXact_LogicalCtl() calls in
> CommitTransaction() and CleanupTransaction(), but it's fine for them
> to differ, since we're holding interrupts in the former but not in the
> latter. Calling AtEOXact_LogicalCtl() after resetting the top-level
> XID would be more bullet-proof, so let's go with this approach.
>
> I've attached the updated patch. Please review it.
Understood, LGTM.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shubhra Jain | 2026-10-06 07:22:12 | Re: Allow pg_read_all_stats to read replication origin status |
| Previous Message | Richard Guo | 2026-10-06 07:08:00 | Re: ERROR: too late to create a new PlaceHolderInfo |