RE: Added missing invalidations for all tables publication

From: "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>
Subject: RE: Added missing invalidations for all tables publication
Date: 2021-09-08 02:27:09
Message-ID: OS3PR01MB5718D92596A0289DC6908A0594D49@OS3PR01MB5718.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> From Mon, Sep 6, 2021 1:56 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > On Tue, Aug 31, 2021 at 8:54 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> > > Thanks for the comments, the attached v3 patch has the changes for
> > > the same.
> > >
> >
> > I think this bug should be fixed in back branches (till v10). OTOH, as
> > this is not reported by any user and we have found it during code
> > review so it seems either users don't have an exact use case or they
> > haven't noticed this yet. What do you people think about back-patching?
>
> Personally, I think it's ok to back-patch.

I found that the patch cannot be applied to back-branches(v10-v14) cleanly,
so, I generate the patches for back-branches. Attached, all the patches have
passed regression test.

Best regards,
Hou zj

Attachment Content-Type Size
v5-HEAD-0001-Invalidate-relcache-for-publications-defined-for-.patch application/octet-stream 5.9 KB
v5-PG10-0001-Invalidate-relcache-for-publications-defined-for-.patch application/octet-stream 4.2 KB
v5-PG11-0001-Invalidate-relcache-for-publications-defined-for-.patch application/octet-stream 4.2 KB
v5-PG12-0001-Invalidate-relcache-for-publications-defined-for-.patch application/octet-stream 4.3 KB
v5-PG13-0001-Invalidate-relcache-for-publications-defined-for-.patch application/octet-stream 4.3 KB
v5-PG14-0001-Invalidate-relcache-for-publications-defined-for-.patch application/octet-stream 5.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-09-08 03:50:08 Re: Estimating HugePages Requirements?
Previous Message Kyotaro Horiguchi 2021-09-08 02:17:36 Re: Improve logging when using Huge Pages