| From: | "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, "pgsql-docs(at)lists(dot)postgresql(dot)org" <pgsql-docs(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: pg_type_d.h location incorrect |
| Date: | 2021-05-28 02:50:48 |
| Message-ID: | OS0PR01MB6113B7765814AC192CA8B420FB229@OS0PR01MB6113.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-docs |
On Thursday, May 27, 2021 11:27 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote
>No ... "patch -p1 <~/improve-pgservice-docs.patch" works fine for me.
Oh, never tried "patch -p1" command before but it worked. Thanks!!
BTW, here is my previous operation to apply your patch(failed, which is strange IMO)
$ git apply --3way improve-pgservice-docs.patch
error: patch failed: doc/src/sgml/libpq.sgml:8091
Falling back to three-way merge...
error: patch failed: doc/src/sgml/libpq.sgml:8091
error: doc/src/sgml/libpq.sgml: patch does not apply
>grepping finds lots of occurrences of '~/' and
>only one of '$HOME/'. Seems like we ought to change that one:
>
>$ grep -r 'HOME/' .
>./config.sgml: This writes out files to <filename>$HOME/.debug/jit/</filename>; the
Agreed, thanks for the comment.
Attached a patch to combine the above fix in your patch.
Also fixed a typo in install-windows.sgml.
Also fixed pgbuffercache.sgml as Michael commented at [1].
[1] https://www.postgresql.org/message-id/YK4A4g07AvGa9FVF%40paquier.xyz
Regards,
Tang
| Attachment | Content-Type | Size |
|---|---|---|
| improve-pgservice-docs-etc.patch | application/octet-stream | 5.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-05-29 18:31:01 | Re: pg_type_d.h location incorrect |
| Previous Message | Tom Lane | 2021-05-27 14:26:45 | Re: pg_type_d.h location incorrect |