| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, "pgsql-docs(at)lists(dot)postgresql(dot)org" <pgsql-docs(at)lists(dot)postgresql(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: pg_type_d.h location incorrect |
| Date: | 2021-05-27 14:26:45 |
| Message-ID: | 1718745.1622125605@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-docs |
"tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com> writes:
> On Thursday, May 27, 2021 10:58 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote
>> So I ended up with the attached --- what do you think?
> The doc-fix LGTM.
> But I couldn't apply the patch at HEAD(2941138e60). Maybe you did the fix at a branch other than HEAD?
No ... "patch -p1 <~/improve-pgservice-docs.patch" works fine for me.
>> Also, looking at this, I note that "~/.pg_service.conf" is still a
>> platform-ism. We could make that slightly better by writing
>> "$HOME/.pg_service.conf", but is that good enough?
> Agreed. Besides, A lot of places in current Doc have been useing ~/.pg_*** already.
> IMHO, it's good to keep the consistency.
Oh, good point ... grepping finds lots of occurrences of '~/' and
only one of '$HOME/'. Seems like we ought to change that one:
$ grep -r 'HOME/' .
./config.sgml: This writes out files to <filename>$HOME/.debug/jit/</filename>; the
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | tanghy.fnst@fujitsu.com | 2021-05-28 02:50:48 | RE: pg_type_d.h location incorrect |
| Previous Message | Michael Paquier | 2021-05-27 10:55:18 | Re: Error building for 64-bit Windows (10) |