| From: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Subject: | RE: Enhanced error message to include hint messages for redundant options error |
| Date: | 2021-05-08 06:31:22 |
| Message-ID: | OS0PR01MB5716ED6E393DDB10D26EBB6094569@OS0PR01MB5716.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> > > Thanks! The v5 patch looks good to me. Let's see if all agree on the
> > > goto duplicate_error approach which could reduce the LOC by ~80.
> >
> > I think the "goto duplicate_error" approach looks good, it avoids
> > duplicating the same error code multiple times.
>
> Thanks. I will mark the v5 patch "ready for committer" if no one has comments.
Hi,
I looked into the patch and noticed a minor thing.
+ return; /* keep compiler quiet */
}
I think we do not need the comment here.
The compiler seems not require "return" at the end of function
when function's return type is VOID.
In addition, it seems better to remove these "return;" like what
commit "3974c4" did.
Best regards,
houzj
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yura Sokolov | 2021-05-08 07:03:35 | Re: plan with result cache is very slow when work_mem is not enough |
| Previous Message | Dilip Kumar | 2021-05-08 05:52:48 | Re: Inaccurate error message when set fdw batch_size to 0 |