| From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
|---|---|
| To: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Inaccurate error message when set fdw batch_size to 0 |
| Date: | 2021-05-08 05:52:48 |
| Message-ID: | CAFiTN-vNAVhsNH52XXMM9Dhs+WQHZ+KAHXVghsp-9QFapg37qg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, May 8, 2021 at 9:09 AM houzj(dot)fnst(at)fujitsu(dot)com
<houzj(dot)fnst(at)fujitsu(dot)com> wrote:
>
> The error message here seems not accurate, because
>
> I can see from the code batch_size should be positive ( > 0).
>
> So, is it better to change the error message to “fetch_size requires a positive integer value” ?
>
> I also found fetch_size has the similar issue, attaching a patch to fix this.
Yes, it should be a positive integer, so your change makes sense.
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | houzj.fnst@fujitsu.com | 2021-05-08 06:31:22 | RE: Enhanced error message to include hint messages for redundant options error |
| Previous Message | Dilip Kumar | 2021-05-08 05:48:48 | Re: Small issues with CREATE TABLE COMPRESSION |