From: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
---|---|
To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, 'Shubham Khanna' <khannashubham1197(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | RE: Add support for specifying tables in pg_createsubscriber. |
Date: | 2025-08-01 08:03:10 |
Message-ID: | OS0PR01MB5716ED430E93B9AEFBF9DF419426A@OS0PR01MB5716.jpnprd01.prod.outlook.com |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Monday, July 28, 2025 1:07 PM Hayato Kuroda (Fujitsu) <kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> Dear Shubham,
>
> > The attached patch introduces a new '--table' option that can be
> > specified after each '--database' argument.
>
> Do we have another example which we consider the ordering of options? I'm
> unsure
> for it. Does getopt_long() always return parsed options with the specified
> order?
>
> > The syntax is like that used in 'vacuumdb'
> > and supports multiple '--table' arguments per database, including
> > optional column lists and row filters.
>
> Vacuumdb nor pg_restore do not accept multiple --database, right?
> I'm afraid that current API has too complex.
We have another example to consider: pg_amcheck, which allows users to specify
multiple databases. Following this precedent, it may be beneficial to adopt a
similar style in pg_createsubscriber. E.g., Users could specify tables using
database-qualified names, such as:
./pg_createsubscriber --database db1 --table 'db1.public.t1' --table
'db1.public.t2(a,b) WHERE a > 100' --database db2 --table 'db2.public.t3'
This approach enables the tool to internally categorize specified tables by
database and create publications accordingly.
Best Regards,
Hou zj
From | Date | Subject | |
---|---|---|---|
Next Message | Chao Li | 2025-08-01 08:10:16 | Re: Raw parse tree is not dumped to log |
Previous Message | Zhijie Hou (Fujitsu) | 2025-08-01 08:02:50 | RE: Add support for specifying tables in pg_createsubscriber. |