Re: Add support for specifying tables in pg_createsubscriber.

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, 'Shubham Khanna' <khannashubham1197(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add support for specifying tables in pg_createsubscriber.
Date: 2025-08-01 12:56:07
Message-ID: 8b9d04fc-958f-4815-9a31-d08fe81181da@dunslane.net
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 2025-08-01 Fr 4:03 AM, Zhijie Hou (Fujitsu) wrote:
> On Monday, July 28, 2025 1:07 PM Hayato Kuroda (Fujitsu)<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>> Dear Shubham,
>>
>>> The attached patch introduces a new '--table' option that can be
>>> specified after each '--database' argument.
>> Do we have another example which we consider the ordering of options? I'm
>> unsure
>> for it. Does getopt_long() always return parsed options with the specified
>> order?
>>
>>> The syntax is like that used in 'vacuumdb'
>>> and supports multiple '--table' arguments per database, including
>>> optional column lists and row filters.
>> Vacuumdb nor pg_restore do not accept multiple --database, right?
>> I'm afraid that current API has too complex.
> We have another example to consider: pg_amcheck, which allows users to specify
> multiple databases.

I don't think that's quite the point, as I understand it. pg_amcheck
might allow you to have multiple --database arguments, but I don't think
it depends on the order of arguments. You didn't answer his question
about what getopt_long() does. I don't recall if it is free to mangle
the argument order.

cheers

andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrei Lepikhov 2025-08-01 13:07:08 Re: Let plan_cache_mode to be a little less strict
Previous Message Andrei Lepikhov 2025-08-01 12:32:51 Correction of RowMark Removal During Sel-Join Elimination