| From: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, 'Dilip Kumar' <dilipbalaut(at)gmail(dot)com> |
| Subject: | RE: [PoC] pg_upgrade: allow to upgrade publisher node |
| Date: | 2023-09-06 05:39:26 |
| Message-ID: | OS0PR01MB5716D4EECE46ABC4B0370AEA94EFA@OS0PR01MB5716.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wednesday, September 6, 2023 11:18 AM Zhijie Hou (Fujitsu) <houzj(dot)fnst(at)fujitsu(dot)com> wrote:
>
> On Tuesday, September 5, 2023 3:35 PM Kuroda, Hayato/黒田 隼人
> <kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> 4.
> + * XXX: As mentioned in comments atop get_output_plugins(), we may
> not
> + * have to consider the uniqueness of entries. If so, we can use
> + * count_old_cluster_logical_slots() instead of plugin_list_length().
> + */
>
> I think check_loadable_libraries() will avoid loading the same library, so it seems
> fine to skip duplicating the plugins and we can save some codes.
Sorry, there is a typo, I mean "deduplicating" instead of " duplicating "
>
> ----
> /* Did the library name change? Probe it. */
> if (libnum == 0 || strcmp(lib, os_info.libraries[libnum -
> 1].name) != 0)
> ----
>
> But if we think duplicating them would be better, I feel we could use the
Here also " duplicating " should be "deduplicating".
Best Regards,
Hou zj
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nishant Sharma | 2023-09-06 05:55:35 | Re: pg_basebackup: Always return valid temporary slot names |
| Previous Message | Peter Smith | 2023-09-06 05:30:39 | Re: [PoC] pg_upgrade: allow to upgrade publisher node |