| From: | Nishant Sharma <nishant(dot)sharma(at)enterprisedb(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Jelte Fennema <me(at)jeltef(dot)nl>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Jim Jones <jim(dot)jones(at)uni-muenster(dot)de> |
| Subject: | Re: pg_basebackup: Always return valid temporary slot names |
| Date: | 2023-09-06 05:55:35 |
| Message-ID: | CADrsxdbSxz+wtpyFirbtPV6=GbCsU5rtzKUwWzv2XAuDdg8hWQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 5, 2023 at 4:40 PM Jelte Fennema <me(at)jeltef(dot)nl> wrote:
> I modified the PgBouncer PR to always set the sign bit to 0. But I
> still I think it makes sense to also address this in pg_basebackup.
Sounds good to me. Thank you!
On Tue, Sep 5, 2023 at 5:36 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> Since the value in the temporary slotname isn't used to convey meaning, but
> merely to ensure uniqueness, I don't think it's unreasonable to guard
> aginst
> malformed input (ie negative integer).
>
Ok. In this case, I also agree.
+1 to the patch from my side. Thank you!
Regards,
Nishant.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2023-09-06 06:00:39 | Re: Wrong rows estimations with joins of CTEs slows queries by more than factor 500 |
| Previous Message | Zhijie Hou (Fujitsu) | 2023-09-06 05:39:26 | RE: [PoC] pg_upgrade: allow to upgrade publisher node |