Open a streamed block for transactional messages during decoding

From: "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Open a streamed block for transactional messages during decoding
Date: 2023-10-24 11:52:01
Message-ID: OS0PR01MB5716AEBD2988F8F5E9D5985794DFA@OS0PR01MB5716.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

While reviewing the test_decoding code, I noticed that when skip_empty_xacts
option is specified, it doesn't open the streaming block( e.g.
pg_output_stream_start) before streaming the transactional MESSAGE even if it's
the first change in a streaming block.

It looks inconsistent with what we do when streaming DML
changes(e.g. pg_decode_stream_change()).

Here is a small patch to open the stream block in this case.

Best Regards,
Hou Zhijie

Attachment Content-Type Size
0001-Open-a-streamed-block-for-transactional-messages-dur.patch application/octet-stream 4.6 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2023-10-24 11:54:28 Re: [PATCH] Tracking statements entry timestamp in pg_stat_statements
Previous Message Devrim Gündüz 2023-10-24 11:46:40 d844cd75a and postgres_fdw