RE: should INSERT SELECT use a BulkInsertState?

From: "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Luc Vlaming <luc(at)swarm64(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>
Subject: RE: should INSERT SELECT use a BulkInsertState?
Date: 2021-03-08 09:07:11
Message-ID: OS0PR01MB5716856C011F6039D49B61DF94939@OS0PR01MB5716.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> > I am very interested in this patch, and I plan to do some experiments with the
> patch.
> > Can you please rebase the patch because it seems can not applied to the
> master now.
>
> Thanks for your interest.
>
> I was sitting on a rebased version since the bulk FDW patch will cause conflicts,
> and since this should maybe be built on top of the table-am patch (2871).
> Have fun :)
Hi,

When I testing with the patch, I found I can not use "\d tablename".
It reports the following error, it this related to the patch?

--------------------------------------------------------------------------
ERROR: did not find '}' at end of input node at character 141
STATEMENT: SELECT pol.polname, pol.polpermissive,
CASE WHEN pol.polroles = '{0}' THEN NULL ELSE pg_catalog.array_to_string(array(select rolname from pg_catalog.pg_roles where oid = any (pol.polroles) order by 1),',') END,
pg_catalog.pg_get_expr(pol.polqual, pol.polrelid),
pg_catalog.pg_get_expr(pol.polwithcheck, pol.polrelid),
CASE pol.polcmd
WHEN 'r' THEN 'SELECT'
WHEN 'a' THEN 'INSERT'
WHEN 'w' THEN 'UPDATE'
WHEN 'd' THEN 'DELETE'
END AS cmd
FROM pg_catalog.pg_policy pol
WHERE pol.polrelid = '58112' ORDER BY 1;
ERROR: did not find '}' at end of input node
LINE 2: ...catalog.array_to_string(array(select rolname from pg_catalog...
--------------------------------------------------------------------------

Best regards,
houzj

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ajin Cherian 2021-03-08 09:13:07 Make stream_prepare an optional callback
Previous Message Michael Paquier 2021-03-08 08:56:58 Re: alter table set TABLE ACCESS METHOD